wiki | forum | trac | otrs | joomla | tech blog | mailman | bewelcome Branches: test.bw | alpha.bw | www.bw Participate: download | get involved

Ticket #460 (assigned improve feature)

Opened 6 months ago

Last modified 3 months ago

Refactoring of forum application

Reported by: lemon-head Assigned to: lemon-head (accepted)
Priority: major Milestone: unassigned
Component: BW Forum Version:
Keywords: Cc:
Follow up needed: review code Frequently reported: 1
Announce on BW: 0

Description

I want to do some improvements on the forum application

Code gardening.

  • replace tabs by spaces, and fix indentation
  • comments using /**..*/

Structural Refactoring

This can be a first step towards the more complex #436 RoxPageView scheme, but it doesn't have to be.

The advantages:

  • Cleaner code (hopefully)
  • Fewer lines wasted for redundant ob_start(), ob_end(), ob_get_contents(). However, this is not as important in the forums application as it is in other apps.
  • The application gets independent from the global PVars::getObj('page') object.
  • Easier transition to #436 RoxPageView scheme.

Change History

03/11/08 19:55:08 changed by lemon-head

  • owner set to lemon-head.
  • status changed from new to assigned.
  • component changed from unknown to BW Forum.

[4339] - does it.

03/11/08 22:15:48 changed by lemon-head

  • follow_up changed from none to review code.

03/13/08 08:41:59 changed by jeanyves

please, I am really on forum, this make the merging a bit more difficult, can you wait a bit ?

except this : space instead of tabs, I am ok /* */ to replace // ? If it is the rule I don't like it they are cases where /* */ are very usefeull to make a block inactive for example

and other case where a // is very good to make a "title comment" before block or an additional comment in the end of a line, if you only use /* */, when you want to make inactive a big bloc you have to deal with all internal /* */, with // you dont have this problem.

May be I misunderstood your intention ?

06/10/08 09:48:50 changed by public

There is a error message in the footer of the forum in alpha: Notice: Undefined variable: versionInfo in /home/bwrox/alpha.bewelcome.org/templates/apps/rox/footer.php on line 82

not sure if this is related to this ticket. crumbking

Trac Customization: trac stylesheet
SourceForge.net Logo