links in emails sent out by forum are broken

Found the problem (or I assume I found it).

• mailbot.php uses 'http://'.$_SYSHCVOL['SiteName'] as a baseuri.
• $_SYSHCVOLSiteName? appears to be undefined, or empty.
• normally, it should be defined in rox_local.ini in root folder on production, like this

  [syshcvol]
  ...
  SiteName = ...
  ...
  

I think in the meantime tobixen knows how the ini files work... so I hope he can fix it.

In general, it would be good to make a check if all the $_SYSHCVOL variables are set to the correct value (both in the ini file, and at runtime for website and cronjobs).

I'm not sure how to debug this, but the config file www.bewelcome.org should be read by the cronjob by now.

Please contact me by irc, google chat or skype, and we'll look into it.

The config was fixed yesterday in rox_local.ini

the SiteName? should be set and commited to www.bewelcome.org.ini

I'm wondering if we need SiteName? at all - I think it's always the same as SERVER_NAME? Maybe the code could be fixed so that "if not defined SiteName?, then set SiteName?=SERVER_NAME"?

I think the idea of SiteName is to make localhost or other environments behave like production. For instance, if we would run the mailbot on old.bewelcome.org, we could still have the emails link to www.bw. Or, on localhost you can have one version that behaves like www.bw, and another that behaves like test.

On the other hand, I think "SiteName" is maybe not the best name for this. Any other idea?